Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DER 144 signature test #305

Open
dzikowski opened this issue Jul 11, 2024 · 2 comments
Open

Fix DER 144 signature test #305

dzikowski opened this issue Jul 11, 2024 · 2 comments

Comments

@dzikowski
Copy link
Collaborator

The test for multiple formats has invalid input. Find the following code in signatures.spec.ts:

// der144Signature
"3045022100f6d3aefb132b74e879a937dc6a28003d6c2acee6e27291bfb24834aa2cd2a610022003a06b8f150ab71b3e19621114f98416417bea4fbc5b3b4a30b610fea9f281e1"

It’s actually der142 (not 144), the length is the same as the prev signature in the test. The test case needs to be fixed by providing valid DER 144-length signature.
@Sarah1100-tech
Copy link

_****_

@Sarah1100-tech
Copy link

@Sarah1100-tech

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dzikowski @Sarah1100-tech