Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FR: Define some common lodash templates for asset naming #82

Closed
1 task done
melink14 opened this issue May 11, 2021 · 2 comments · Fixed by #96
Closed
1 task done

FR: Define some common lodash templates for asset naming #82

melink14 opened this issue May 11, 2021 · 2 comments · Fixed by #96
Labels
enhancement New feature or request released

Comments

@melink14
Copy link

melink14 commented May 11, 2021 •
edited
Loading

FR: Define some common lodash templates for asset namin

  • I have searched the issues of this repository and believe that this is not a duplicate.

What you did and problem description

I would like to include version number in my zip file asset (since it will also be published to github) but depending on the environment that's not easy to do. (ex extensionname_v1.1.1.zip

What happened

Right now it doesn't support templating so I got extensionname_${nextRelease.version}.zip as the file name.

Suggested solution

I think supporting lodash templates like many of the other semantic relaese plugins should be easy enough:
Here's an example from git plugin: https://github.com/semantic-release/git/blob/11ef559f896fa110dfe9606cfab52e0b47ed48b4/lib/prepare.js#L65
@melink14
Copy link
Author

This is less important for me since I saw github extension takes a separate name argument which allows using lodash templates.

@GabeDuarteM GabeDuarteM added the enhancement New feature or request label Jul 5, 2022
@GabeDuarteM GabeDuarteM self-assigned this Jul 8, 2022
GabeDuarteM added a commit that referenced this issue Jul 8, 2022
@GabeDuarteM
feat(templating): Add templating features to the asset parameter.
392b2fe 
The following variables are available: `branch`, `lastRelease`, `nextRelease` and `commits`. Search on the [plugins](https://github.com/semantic-release/semantic-release/blob/master/docs/developer-guide/plugin.md) documentation to see the type of those objects.
Example: `my-extension_v${nextRelease.version}_${branch.name}.zip` will result in something like `my-extension_v2.3.1_main.zip`

Closes #82
@GabeDuarteM GabeDuarteM mentioned this issue Jul 8, 2022
Merged
GabeDuarteM added a commit that referenced this issue Jul 8, 2022
@GabeDuarteM
feat(templating): Add templating features to the asset parameter.
db93147 
The following variables are available: `branch`, `lastRelease`, `nextRelease` and `commits`. Search on the [plugins](https://github.com/semantic-release/semantic-release/blob/master/docs/developer-guide/plugin.md) documentation to see the type of those objects.
Example: `my-extension_v${nextRelease.version}_${branch.name}.zip` will result in something like `my-extension_v2.3.1_main.zip`

Closes #82
@GabeDuarteM GabeDuarteM removed their assignment Jul 8, 2022
@github-actions
Copy link

github-actions bot commented Jul 8, 2022

🎉 This issue has been resolved in version 3.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
2 participants
@melink14 @GabeDuarteM