Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with ticon to TF compat #53

Closed
3 tasks done
chochem opened this issue Apr 1, 2024 · 8 comments · Fixed by #56
Closed
3 tasks done

Problems with ticon to TF compat #53

chochem opened this issue Apr 1, 2024 · 8 comments · Fixed by #56

Comments

@chochem
Copy link
Member

chochem commented Apr 1, 2024

Your GTNH Discord Username

chochem

Your Pack Version

GTNH 2.6.0 beta1

Your Server

SP

Java Version

Java 21

Type of Server

Single Player

Your Expectation

image

The Reality

Edit: this compat is now disabled in GTNH which resolves some of these issues but not others, which are still relevant for use outside of GTNH:

image
(resolved)
this is clearly caused by this strange nuggetknightmetel oredict
image
(unresolved)

Also:

image
(unresolved)
image
(unresolved)

there is also duplicate ticon materials for things like knightmetal. (resolved)

And there are nugget->ingot and ingot->nugget crafting grid recipes. (resolved)

And ticon fluids and recycling where sofar we have been using a gt fluid and gt recycling. (resolved)

Your Proposal

remove the oredict

Final Checklist

  • I have searched this issue tracker and there is nothing similar already. Posting on a closed issue saying the bug still exists will prompt us to investigate and reopen it once we confirm your report.
  • I can reproduce this problem consistently by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
  • I have asked other people and they confirm they also have this problem by follow the exact steps I described above, or this does not need reproducing, e.g. recipe loophole.
@chochem
Copy link
Member Author

chochem commented Apr 1, 2024

looks like its fine in nightly-353. so this was broken between then and the beta.

@chochem
Copy link
Member Author

chochem commented Apr 1, 2024

caused by #39

@chochem
Copy link
Member Author

chochem commented Apr 1, 2024

also affects a bunch of other tinker items like wood and stone tool rods, or the stack of paper

@chochem
Copy link
Member Author

chochem commented Apr 1, 2024

there is more here that makes it clear this is not meant for gtnh. like ingot-> nugget and nugget->ingot recipes or alternative recycling recipes. So that is the way I will go for now.
I should ping @Gordon-Frohman though, to get some insight or maybe fixes

@chochem chochem changed the title Slime Crystal uncraftable due to weird knightmetal oredict Problems with ticon to TF compat Apr 2, 2024
@chochem chochem transferred this issue from GTNewHorizons/GT-New-Horizons-Modpack Apr 2, 2024
@chochem
Copy link
Member Author

chochem commented Apr 2, 2024

one other question Dream brought up is if we want to apply the new effects to the exsting tgregworks tools in GTNH. (or something along those lines like replacing them)

@Gordon-Frohman
Copy link

Good morning everyone. I'll look through the mod's files to fix the ore dictionary issue. Do I understand correctly, you want to add the effects I already implemented to materials present in the pack? I don't really mind disabling integration for GTNH, since I do not play it :D

@Dream-Master
Copy link
Member

Good morning everyone. I'll look through the mod's files to fix the ore dictionary issue. Do I understand correctly, you want to add the effects I already implemented to materials present in the pack? I don't really mind disabling integration for GTNH, since I do not play it :D

If the Effec is nice i like to add it to GTNH but with right ore dicts. Sure the materials need to be disabled via TGregworks to not have 2 variants in the pack.

@chochem
Copy link
Member Author

chochem commented Apr 3, 2024

Good morning everyone. I'll look through the mod's files to fix the ore dictionary issue. Do I understand correctly, you want to add the effects I already implemented to materials present in the pack? I don't really mind disabling integration for GTNH, since I do not play it :D

Hi. Thanks for clarifying that indeed this wasnt meant for GTNH. That makes sense. The oredict issues will still affect you though, yes.

In GTNH these materials already have tinker compact, or more precisely they have gt materials which have tinker compat. This is not quite the same as they of course use gt machines over smeltery and gt fluids instead of added tinker fluids, etc. I prefer that over the swap dream mentions, because it actually works with the gt materials nicely. That also includes the recycling recipes for example. We already got that stuff, just with GT machines and materials.

Of course we also dont want other stuff like nugget to ingot crafting recipe.

But yea the effects might be nice, ideally with the tgregworks materials, we can try to look into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants