-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug Fix Issue-940 #991
Merged
Merged
Bug Fix Issue-940 #991
+653
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
aj-stein-gsa
requested changes
Dec 12, 2024
Gabeblis
force-pushed
the
constraints/issue-940
branch
from
December 12, 2024 16:49
611f018
to
ae4401b
Compare
aj-stein-gsa
requested changes
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gabeblis
force-pushed
the
constraints/issue-940
branch
from
December 12, 2024 19:54
ae4401b
to
2145543
Compare
aj-stein-gsa
approved these changes
Dec 13, 2024
wandmagic
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Notes
Purpose
This PR aims to fix a bug where unexpected behavior was encountered when dealing with multiple diagrams with the following constraints:
has-authorization-boundary-diagram-link-href-target
,has-data-flow-diagram-link-href-target
, andhas-network-architecture-diagram-link-href-target
.Changes
All Submissions:
- [ ] If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated.?Not applicable.By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.