Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug Fix Issue-940 #991

Merged
merged 3 commits into from
Dec 13, 2024
Merged

Bug Fix Issue-940 #991

merged 3 commits into from
Dec 13, 2024

Conversation

Gabeblis
Copy link
Contributor

@Gabeblis Gabeblis commented Dec 11, 2024

Committer Notes

Purpose

This PR aims to fix a bug where unexpected behavior was encountered when dealing with multiple diagrams with the following constraints: has-authorization-boundary-diagram-link-href-target, has-data-flow-diagram-link-href-target, and has-network-architecture-diagram-link-href-target.

Changes

  • Fixed constraints so that they are able to successfully handle multiple diagrams.
  • Added new valid ssp content file to test the case of multiple diagrams.

All Submissions:

  • Have you selected the correct base branch per Contributing guidance?
  • Have you set "Allow edits and access to secrets by maintainers"?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you squashed any non-relevant commits and commit messages? [instructions]
  • Have you added an explanation of what your changes do and why you'd like us to include them?
    - [ ] If applicable, have all FedRAMP Documents Related to OSCAL Adoption affected by the changes in this issue have been updated.? Not applicable.
  • If applicable, does this PR reference the issue it addresses and explain how it addresses the issue?

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis requested a review from a team as a code owner December 11, 2024 19:24
@Gabeblis Gabeblis linked an issue Dec 11, 2024 that may be closed by this pull request
12 tasks
@Gabeblis Gabeblis marked this pull request as draft December 12, 2024 14:26
@Gabeblis Gabeblis force-pushed the constraints/issue-940 branch from 611f018 to ae4401b Compare December 12, 2024 16:49
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per the @Telos-sa user feedback in #940, can we please add tests for multiple diagrams for data-flow, authz-boundary, and network-arch work as intended and not presume single count? Thanks.

@Gabeblis Gabeblis force-pushed the constraints/issue-940 branch from ae4401b to 2145543 Compare December 12, 2024 19:54
@Gabeblis Gabeblis marked this pull request as ready for review December 12, 2024 19:55
@Gabeblis Gabeblis self-assigned this Dec 12, 2024
@Gabeblis Gabeblis requested a review from a team December 12, 2024 19:59
@Gabeblis
Copy link
Contributor Author

Per the @Telos-sa user feedback in #940, can we please add tests for multiple diagrams for data-flow, authz-boundary, and network-arch work as intended and not presume single count? Thanks.

Done. 👍

@Gabeblis Gabeblis changed the title Issue-940 WIP Bug Fix Issue-940 Dec 12, 2024
@Gabeblis Gabeblis mentioned this pull request Dec 13, 2024
7 tasks
@wandmagic wandmagic merged commit c5399c4 into GSA:develop Dec 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Constraint error while processing expression: Diagrams
3 participants