-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add component-has-authentication-method
Constraint
#927
Conversation
src/validations/constraints/content/ssp-component-has-authentication-method-INVALID.xml
Outdated
Show resolved
Hide resolved
b829bc6
to
7ac54e5
Compare
@wandmagic Any idea why the tests are failing here when they weren't yesterday? |
were they passing yesterday? it looks like a red X |
|
Yeah they all pass locally, and they passed yesterday. Nothing changed. Not sure why it says 50% now |
that is odd, passes locally for me too! |
src/validations/constraints/content/ssp-component-has-authentication-method-INVALID.xml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Committer Notes
Purpose
This PR introduces a new constraint called
component-has-authentication-method
, which ensures that appropriate components dealing with leveraged systems, interconnections, and authorized services include the authentication-method property with a cardinality of 1 or greater.Changes
Added Constraint:
component-has-authentication-method
: Validates that theauthentication-method
prop is present (cardinality >= 1) in components meeting any of the following criteria:Test Data
Invalid Test Data File: Demonstrates cases where components meeting the above criteria are missing the authentication-method property.
Valid Test Data File: Demonstrates successful cases where all relevant components include the authentication-method property.
Added YAML Files
All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.