-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user-authentication
Allowed Values
#921
Conversation
191925f
to
5b8bbe1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question that seems important, otherwise looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I apologize for this, but we were reviewing the acceptance criteria and noticed that we should have adjust the property name, but did not.
Can you re-review the updated issue requirements? I apologize in advance. Other than that, this PR is very solid.
e34c71a
to
c589260
Compare
87c02dc
87c02dc
to
ac6d9b3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me Gabe :)
Committer Notes
Purpose
This PR aims to ensure that only the proper allowed values are used when determining if leveraged authorizations require user authentication.
Changes
Added Constraint:
user-authentication
: This constraint enforces that the user-authentication property in the SSP only allows the following enumerated values: (yes
,no
,not-applicable
).Test Data:
1 Invalid Test Data File
: Demonstrates a failure case where the user-authentication property has an invalid value.1 Valid Test Data File
: Demonstrates a valid case where the user-authentication property has a valid value.Added YAML Files:
2 YAML files
: Included pass and fail YAML files.All Submissions:
By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.