Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user-authentication Allowed Values #921

Merged
merged 5 commits into from
Nov 25, 2024

Conversation

Gabeblis
Copy link
Contributor

@Gabeblis Gabeblis commented Nov 20, 2024

Committer Notes

Purpose

This PR aims to ensure that only the proper allowed values are used when determining if leveraged authorizations require user authentication.

Changes

Added Constraint:

  • user-authentication: This constraint enforces that the user-authentication property in the SSP only allows the following enumerated values: (yes, no, not-applicable).

Test Data:

  • 1 Invalid Test Data File: Demonstrates a failure case where the user-authentication property has an invalid value.
  • 1 Valid Test Data File: Demonstrates a valid case where the user-authentication property has a valid value.

Added YAML Files:

  • 2 YAML files: Included pass and fail YAML files.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis self-assigned this Nov 20, 2024
@Gabeblis Gabeblis requested a review from a team as a code owner November 20, 2024 20:07
@Gabeblis Gabeblis linked an issue Nov 20, 2024 that may be closed by this pull request
18 tasks
@Gabeblis Gabeblis force-pushed the constaints/issue-891 branch 2 times, most recently from 191925f to 5b8bbe1 Compare November 20, 2024 20:22
wandmagic
wandmagic previously approved these changes Nov 20, 2024
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question that seems important, otherwise looks good.

wandmagic
wandmagic previously approved these changes Nov 20, 2024
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apologize for this, but we were reviewing the acceptance criteria and noticed that we should have adjust the property name, but did not.

Can you re-review the updated issue requirements? I apologize in advance. Other than that, this PR is very solid.

@Gabeblis
Copy link
Contributor Author

Gabeblis commented Nov 21, 2024

[e34c71a](/GSA/fedramp-automation/pull/921/commits/e34c71a2fa34b9d3c5adc9ea6871c0fc1e1d2bfa)

I corrected the constraint target per Brian's feedback on #891. This constraint now targets all the various acceptable component types. Changes here: c589260

wandmagic
wandmagic previously approved these changes Nov 21, 2024
DimitriZhurkin
DimitriZhurkin previously approved these changes Nov 21, 2024
aj-stein-gsa
aj-stein-gsa previously approved these changes Nov 22, 2024
wandmagic
wandmagic previously approved these changes Nov 22, 2024
Copy link

@kyhu65867 kyhu65867 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me Gabe :)

@Rene2mt Rene2mt merged commit edc5a7a into GSA:develop Nov 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check allowed values for user authentication
6 participants