Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system-characteristics 'information-type' constraints #685

Conversation

Gabeblis
Copy link
Contributor

@Gabeblis Gabeblis commented Sep 11, 2024

Committer Notes

{Please provide a description of what this PR accomplishes. Be sure to reference any issues addressed. If the PR is a work-in-progress submitted for early review, please submit the PR as a draft PR using the "Draft pull request" dropdown.}

Description

Added system-characteristics 'information-type' constraints and tests for each of the constraints. These should be added as they are part of the effort write all of the constraints from the constraint tracker.

Changes

  • Added constraints information-type-has-confidentiality-impact, information-type-has-integrity-impact, information-type-has-availability-impact to fedramp-external-constraints.xml.
  • Added pass and fail yaml tests for all of the above constraints.
  • Edited ssp-all-INVALID.xml to ensure all constraints fail correctly.

All Submissions:

By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.

@Gabeblis Gabeblis requested a review from a team as a code owner September 11, 2024 18:10
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this also have overlap with #610? Seems so.

@Gabeblis
Copy link
Contributor Author

Does this also have overlap with #610? Seems so.

These constraints should all exist. The only overlap is the issue that we discussed yesterday with Dave regarding allowed-values constraints and expect constraints sharing the same ssp-all-INVALID file.

@aj-stein-gsa
Copy link
Contributor

Does this also have overlap with #610? Seems so.

These constraints should all exist. The only overlap is the issue that we discussed yesterday with Dave regarding allowed-values constraints and expect constraints sharing the same ssp-all-INVALID file.

OK disregard, I can see what you mean. I am still going to need to wrap up some docs pertaining to the doc gaps for this and #610 tracked in GSA/automate.fedramp.gov#55. Sorry for the delayed reply.

@Gabeblis Gabeblis force-pushed the constraints/system-characteristics/information-type branch 2 times, most recently from 1e9ae83 to 3906d7d Compare September 20, 2024 19:04
@aj-stein-gsa aj-stein-gsa force-pushed the feature/external-constraints branch from c59e72c to f6d2009 Compare September 24, 2024 02:28
@Gabeblis Gabeblis force-pushed the constraints/system-characteristics/information-type branch 2 times, most recently from a91c40a to c357643 Compare September 25, 2024 02:32
@Gabeblis Gabeblis changed the base branch from feature/external-constraints to develop September 26, 2024 19:27
@Gabeblis Gabeblis force-pushed the constraints/system-characteristics/information-type branch from c1d7500 to 741e9b7 Compare September 27, 2024 18:43
@Gabeblis Gabeblis force-pushed the constraints/system-characteristics/information-type branch from 741e9b7 to 9031efc Compare October 29, 2024 19:26
@Gabeblis Gabeblis requested a review from a team as a code owner October 29, 2024 19:26
@Gabeblis Gabeblis requested a review from aj-stein-gsa October 29, 2024 19:38
@Gabeblis Gabeblis force-pushed the constraints/system-characteristics/information-type branch from d5768dc to 858f9f8 Compare October 30, 2024 03:05
@aj-stein-gsa aj-stein-gsa merged commit d0ed82e into GSA:develop Oct 30, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚢 Ready to Ship
Development

Successfully merging this pull request may close these issues.

4 participants