-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add system-characteristics 'information-type' constraints #685
Add system-characteristics 'information-type' constraints #685
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this also have overlap with #610? Seems so.
These constraints should all exist. The only overlap is the issue that we discussed yesterday with Dave regarding allowed-values constraints and expect constraints sharing the same ssp-all-INVALID file. |
OK disregard, I can see what you mean. I am still going to need to wrap up some docs pertaining to the doc gaps for this and #610 tracked in GSA/automate.fedramp.gov#55. Sorry for the delayed reply. |
1e9ae83
to
3906d7d
Compare
c59e72c
to
f6d2009
Compare
a91c40a
to
c357643
Compare
c1d7500
to
741e9b7
Compare
741e9b7
to
9031efc
Compare
src/validations/constraints/unit-tests/information-type-has-availability-impact-PASS.yaml
Outdated
Show resolved
Hide resolved
src/validations/constraints/unit-tests/information-type-has-confidentiality-impact-FAIL.yaml
Outdated
Show resolved
Hide resolved
src/validations/constraints/unit-tests/information-type-has-confidentiality-impact-PASS.yaml
Outdated
Show resolved
Hide resolved
src/validations/constraints/unit-tests/information-type-has-integrity-impact-FAIL.yaml
Outdated
Show resolved
Hide resolved
src/validations/constraints/unit-tests/information-type-has-integrity-impact-PASS.yaml
Outdated
Show resolved
Hide resolved
d5768dc
to
858f9f8
Compare
Committer Notes
{Please provide a description of what this PR accomplishes. Be sure to reference any issues addressed. If the PR is a work-in-progress submitted for early review, please submit the PR as a draft PR using the "Draft pull request" dropdown.}
Description
Added system-characteristics 'information-type' constraints and tests for each of the constraints. These should be added as they are part of the effort write all of the constraints from the constraint tracker.
Changes
All Submissions:
If applicable, does this PR reference the issue it addresses and explain how it addresses the issue?By submitting a pull request, you are agreeing to provide this contribution under the CC0 1.0 Universal public domain dedication.