Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Data Centers documentation #96

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

Gabeblis
Copy link
Contributor

Description

Updated Data Centers documentation to account for a bug found with the current implementation of the data-center props.

@Gabeblis Gabeblis self-assigned this Oct 24, 2024
@Gabeblis
Copy link
Contributor Author

@aj-stein-gsa @kyhu65867 When you get a chance, please give this a quick review to make sure it aligns with the solution for the bug found in GSA/fedramp-automation#818.

@Gabeblis Gabeblis linked an issue Oct 24, 2024 that may be closed by this pull request
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but can adjust the feedback referenced in the tracking release PR into main in this PR here.

#45 (comment)

@Gabeblis
Copy link
Contributor Author

This looks good, but can adjust the feedback referenced in the tracking release PR into main in this PR here.

#45 (comment)

Done: 7f31e85

@Gabeblis Gabeblis requested a review from aj-stein-gsa October 24, 2024 17:06
Copy link
Contributor

@aj-stein-gsa aj-stein-gsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you sir, looks good to me.

@wandmagic wandmagic merged commit 83d3ed6 into develop Oct 25, 2024
1 check passed
Copy link

@kyhu65867 kyhu65867 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanted to know your thoughts on this

@kyhu65867
Copy link

(Whoops I didn't realize this was merged already disregard)

@Gabeblis Gabeblis deleted the update-data-centers-documentation branch October 29, 2024 06:02
aj-stein-gsa pushed a commit that referenced this pull request Nov 12, 2024
* Update data-center documentation

* change for clarity
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants