Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add single field component types vertical slice #272

Open
3 of 28 tasks
jimmoffet opened this issue Jul 22, 2024 · 2 comments
Open
3 of 28 tasks

Add single field component types vertical slice #272

jimmoffet opened this issue Jul 22, 2024 · 2 comments
Assignees

Comments

@jimmoffet
Copy link
Contributor

jimmoffet commented Jul 22, 2024

Overview

As a pardon office form builder, I would like be able to add all the components I need to create the presidential pardon form, so that I don't have to think about validation for common form inputs.

Context

REFERENCE: USWDS components for address, dob, email, gender, name, phone, pronouns, etc... are in the user profile components page of the USWDS guidance

We should also pay good attention to the USWDS forms controls guidance

Missing components:

NEEDS DESIGN & SCOPING (these are not ready yet):

  • Signature (discussed with pardon team, eng prototype is here, needs design, is NOT blocking pardon's first draft or user testing)

READY:

Acceptance Criteria

Required outcomes of the story

  • [ ]

Research Questions

  • Optional: Any initial questions for research

Tasks

Research, design, and engineering work needed to complete the story.

  • [ ]

Definition of done

The "definition of done" ensures our quality standards are met with each bit of user-facing behavior we add. Everything that can be done incrementally should be done incrementally, while the context and details are fresh. If it’s inefficient or “hard” to do so, the team should figure out why and add OPEX/DEVEX backlog items to make it easier and more efficient.

  • Behavior
    • Acceptance criteria met
    • Implementation matches design decisions
  • Documentation
    • ADRs (/documents/adr folder)
    • Relevant README.md(s)
  • Code quality
    • Code refactored for clarity and no design/technical debt
    • Adhere to separation of concerns; code is not tightly coupled, especially to 3rd party dependencies; dependency rule followed
    • Code is reviewed by team member
    • Code quality checks passed
  • Security and privacy
    • Automated security and privacy gates passed
  • Testing tasks completed
    • Automated tests pass
    • Unit test coverage of our code >= 90%
  • Build and deploy
    • Build process updated
    • API(s) are versioned
    • Feature toggles created and/or deleted. Document the feature toggle
    • Source code is merged to the main branch

Decisions

  • Optional: Any decisions we've made while working on this story
@jimmoffet jimmoffet changed the title Add missing component types Add missing component types vertical slice [needs refinement] Sep 5, 2024
@JennyRichards-Flexion JennyRichards-Flexion changed the title Add missing component types vertical slice [needs refinement] Add single field component types vertical slice [needs refinement] Sep 24, 2024
@jimmoffet jimmoffet changed the title Add single field component types vertical slice [needs refinement] Add single field component types vertical slice Oct 8, 2024
@JennyRichards-Flexion
Copy link
Contributor

Ethan has a good instructive PR that was discussed in the last dev coffee - all the files that need to be touched are discussed there. Might be a good straightforward introduction.

@JennyRichards-Flexion
Copy link
Contributor

Started Friday 10/25. Unable to estimate time at this time, roughly 2 days.
Currently working on Select.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants