Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAC System Diagram design #944

Closed
4 tasks done
ChrisB-16 opened this issue Apr 5, 2023 · 5 comments · Fixed by #1141
Closed
4 tasks done

FAC System Diagram design #944

ChrisB-16 opened this issue Apr 5, 2023 · 5 comments · Fixed by #1141
Assignees
Labels
compliance Stuff which may relate to a specific requirement or timelines for resolution

Comments

@ChrisB-16
Copy link
Contributor

ChrisB-16 commented Apr 5, 2023

Tasks

`Design draft FAC diagram to outline ATO boundary & cloud services from external systems

  • Gain access to Lucid charts-convert current diagram
  • insert technical details from Development huddle notes- JeanMarie
  • Track requirements from Security Architecture Review Checklist (ISSM/ISSO )
  • perform review session with System Owner on draft before team release for review cycle
@ChrisB-16 ChrisB-16 self-assigned this Apr 5, 2023
@ChrisB-16
Copy link
Contributor Author

Actions are in progress

@ChrisB-16
Copy link
Contributor Author

ChrisB-16 commented Apr 14, 2023

New FAC ATO Boundary diagram draft ready for review: FAC Cloud ATO high-level systems overview v1

https://github.com/GSA-TTS/FAC/tree/jm/Context_with_AV_and_PostgREST/docs/architecture/diagrams

Please feel free to provide comments for updates needed. @jadudm @mogul @JeanMarie-TTS @LindsayYoung

Regards,

@JeanMarie-PM
Copy link
Contributor

JeanMarie-PM commented Apr 14, 2023

@ChrisB-16 , I update the puml file to include the proxy services.
@mogul , Do you mind creating a markdown file so we don't have to generate png files? You can access the file in the branch linked in this ticket.

@JeanMarie-PM
Copy link
Contributor

@mogul , I copied the pull file into an md file with a mermaid tag. But cannot get the diagram to render.

@mogul
Copy link
Contributor

mogul commented Apr 17, 2023

I made a couple commits showing the problems. See these lines in particular:
5556cf5#diff-d6179519cc87ef13a90c45e9f71d3210ed203cb8ecde76b1734cc49dff87e0fcR56-R60

We should check if relationships with boundaries are supposed to be possible in C4-PlantUML... If not, then we should fix that in our diagram. Otherwise, given the state of Mermaid's support for C4, it may be a good example to point out a bug to them in the issue where this support is being discussed.

@mogul mogul added the compliance Stuff which may relate to a specific requirement or timelines for resolution label May 11, 2023
@JeanMarie-PM JeanMarie-PM linked a pull request May 19, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compliance Stuff which may relate to a specific requirement or timelines for resolution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants