Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.11.0 #48

Merged
merged 14 commits into from
Feb 23, 2023
Merged

5.11.0 #48

merged 14 commits into from
Feb 23, 2023

Conversation

ppouchin
Copy link
Member

No description provided.

@@ -124,14 +124,44 @@
*/
public static <T extends GenericObjectWrapper<?>> List<T> distinct(Collection<? extends T> objects) {
return objects.stream()
.collect(Collectors.toMap(T::getId, o -> o))
.collect(Collectors.toMap(T::getId, o -> o, (o1, o2) -> o1))

Check notice

Code scanning / CodeQL

Useless parameter

The parameter 'o2' is never used.
List<U> flatten(Collection<? extends Collection<? extends U>> lists) {
return lists.stream()
.flatMap(Collection::stream)
.collect(Collectors.toMap(U::getId, o -> o, (o1, o2) -> o1))

Check notice

Code scanning / CodeQL

Useless parameter

The parameter 'o2' is never used.
public static <T extends ShapeData, U extends GenericShapeWrapper<? extends T>> U wrap(T object) {
U converted;

if (object instanceof RectangleData) {

Check notice

Code scanning / CodeQL

Chain of 'instanceof' tests

This if block performs a chain of 8 type tests - consider alternatives, e.g. polymorphism or the visitor pattern.
U wrapRepositoryObject(T object) {
U converted;

if (object instanceof ProjectData) {

Check notice

Code scanning / CodeQL

Chain of 'instanceof' tests

This if block performs a chain of 8 type tests - consider alternatives, e.g. polymorphism or the visitor pattern.
*/
public static <T extends DataObject, U extends GenericObjectWrapper<? extends T>> U wrap(T object) {
U converted;
if (object instanceof ShapeData) {

Check notice

Code scanning / CodeQL

Chain of 'instanceof' tests

This if block performs a chain of 9 type tests - consider alternatives, e.g. polymorphism or the visitor pattern.
assertEquals(2, images.size());
List<ImageWrapper> images2 = client.getImagesPairKeyValue("testKey1", "testValue1");

Check notice

Code scanning / CodeQL

Deprecated method or constructor invocation

Invoking [Client.getImagesPairKeyValue](1) should be avoided because it has been deprecated.
@codecov
Copy link

codecov bot commented Feb 23, 2023

Codecov Report

Base: 92.12% // Head: 91.68% // Decreases project coverage by -0.45% ⚠️

Coverage data is based on head (2193353) compared to base (a956dab).
Patch coverage: 93.11% of modified lines in pull request are covered.

❗ Current head 2193353 differs from pull request most recent head cec8a49. Consider uploading reports for the commit cec8a49 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##               main      #48      +/-   ##
============================================
- Coverage     92.12%   91.68%   -0.45%     
- Complexity      905     1035     +130     
============================================
  Files            39       43       +4     
  Lines          2641     2981     +340     
  Branches        214      235      +21     
============================================
+ Hits           2433     2733     +300     
- Misses          156      197      +41     
+ Partials         52       51       -1     
Impacted Files Coverage Δ
...igred/omero/annotations/FileAnnotationWrapper.java 78.78% <ø> (-3.04%) ⬇️
.../igred/omero/annotations/MapAnnotationWrapper.java 91.66% <ø> (-8.34%) ⬇️
.../igred/omero/annotations/TagAnnotationWrapper.java 88.88% <ø> (-11.12%) ⬇️
...java/fr/igred/omero/exception/AccessException.java 50.00% <ø> (ø)
...ava/fr/igred/omero/exception/ExceptionHandler.java 100.00% <ø> (ø)
...ava/fr/igred/omero/exception/OMEROServerError.java 50.00% <ø> (ø)
...ava/fr/igred/omero/exception/ServiceException.java 100.00% <ø> (ø)
.../java/fr/igred/omero/meta/ExperimenterWrapper.java 95.83% <ø> (-4.17%) ⬇️
...rc/main/java/fr/igred/omero/meta/GroupWrapper.java 92.30% <ø> (ø)
...ain/java/fr/igred/omero/meta/PlaneInfoWrapper.java 87.71% <ø> (ø)
... and 46 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 40 Code Smells

94.1% 94.1% Coverage
0.0% 0.0% Duplication

@ppouchin ppouchin merged commit a7b918b into main Feb 23, 2023
@ppouchin ppouchin deleted the 5_11 branch February 23, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant