Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restart from checkpoint with inconsistent box sizes #182

Open
KAClough opened this issue Jun 24, 2021 · 0 comments
Open

Restart from checkpoint with inconsistent box sizes #182

KAClough opened this issue Jun 24, 2021 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@KAClough
Copy link
Member

Changing box sizes on a restart can lead to problems where finer levels get stuck and can't regrid. This happens for example if you started with a block factor of 16 and later increase it to 32. It is a particular issue for restarting from the IC solver, where the grid setup can be quite different.

This should be picked up when restarting and call a Mayday error.

Suggestion by @mirenradia:

In GRAMRLevel::readCheckpointLevel, we can iterate through the read Vector object (the one read in these lines: https://github.com/GRChombo/GRChombo/blob/4baece8164eef6fae5e1b29d929ef324d9e8081b/Source/GRChomboCore/GRAMRLevel.cpp#L660-L666) and check, for each box in the vector, that their longest side is <= max_box_size and block_factor divides the length of all sides.

@KAClough KAClough added the bug Something isn't working label Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants