You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed the SmallDataIO::get_specific_data_line looks for the line corresponding to a specific 'time' requested as an argument, but this is searched through the whole line and not just the first column, which means that if by any change the coordinate (time) happens to match some of the data on a given line (but not the actual time) then SmallDataIO will think it found the correct line.
Explicit example:
BBH example with cheap params
Punctures are at (6,8,0) and (10,8,0)
I ran and decided to restart at t=8 (not fine tuned, I actually want to restart at that point!)
The Puncture tracker was for some reason setting the punctures to (6,8,0) and (10,8,0) (the ones of t=0)
Well, not necessarily just the first column. It will depend on the length of a_coords. But yes, I agree that we should restrict to the substring corresponding to the "coords" columns only.
Hey,
I noticed the
SmallDataIO::get_specific_data_line
looks for the line corresponding to a specific 'time' requested as an argument, but this is searched through the whole line and not just the first column, which means that if by any change the coordinate (time) happens to match some of the data on a given line (but not the actual time) then SmallDataIO will think it found the correct line.Explicit example:
Indeed has an 8.0000000000, so the
SmallDataIO::get_specific_data_line
stops there and assumes it found t=8, since "8" is in that lineExplicit place where the bug is in
SmallDataIO.cpp
:I guess we need to replace this by looking just at the first column.
The text was updated successfully, but these errors were encountered: