Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl JsonSchema for Date/Time #104

Open
ralpha opened this issue Sep 8, 2021 · 2 comments
Open

Impl JsonSchema for Date/Time #104

ralpha opened this issue Sep 8, 2021 · 2 comments

Comments

@ralpha
Copy link
Contributor

ralpha commented Sep 8, 2021

Rocket uses Date and Time as shown here https://docs.rs/rocket/0.5.0-rc.1/rocket/form/trait.FromFormField.html#impl-FromFormField%3C%27v%3E-for-Date in it internal implementations and exposes them to be used.

Schemars does not implement JsonSchema for them yet.
But note that Rocket might update them to time 0.3.2 in the future. So maybe just implement them for 0.3.2 immediately.

@ittorchbearer
Copy link

ittorchbearer commented Apr 20, 2022

I believe I have this and DateTime implemented on my repo: https://github.com/Plato-solutions/Rocket
Not enough time to get pull requests out atm. https://github.com/Plato-solutions/Rocket

@kontsaki
Copy link

Hello, is this still relevant and something worth creating a PR for? Since Rocket now uses time and also it seems time is a relevant lib again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants