Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to use code from a library that has been compiled with new react jsx transform #20

Open
cmdcolin opened this issue Sep 2, 2021 · 1 comment

Comments

@cmdcolin
Copy link
Contributor

cmdcolin commented Sep 2, 2021

I had a tsconfig in react-msaview that said

https://www.typescriptlang.org/docs/handbook/jsx.html

jsx:"react-jsx"

This outputted code using the "new jsx transform" from react

https://reactjs.org/blog/2020/09/22/introducing-the-new-jsx-transform.html

changing to jsx:"react"

worked

The error message from when it wasn't working is

Error: 'jsx' is not exported by node_modules/react/jsx-runtime.js, imported by node_modules/react-msaview/dist/components/ImportForm.js

at /home/cdiesh/src/jbrowse-plugin-msaview/node_modules/react-msaview/dist/components/ImportForm.js:12:9

@cmdcolin
Copy link
Contributor Author

cmdcolin commented Sep 2, 2021

not really a high priority, just notable as some libraries may output this by default more perhaps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant