Add sequence adapter config in afterAttach for baseTrackConfig #4037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs label triage
cmdcolin
added
enhancement
cmdcolin
force-pushed
the
basetrack_add_sequenceadapter
branch
from
96edcaa
to
305e7d0
Compare
|
this has a working proof of concept in the volvox config now code is a little hacky and needs work still, but i think it is still a nice step forward and a proof of concept can visit https://jbrowse.org/code/jb2/basetrack_add_sequenceadapter/?config=test_data%2Fvolvox%2Fconfig.json&session=share-3DJABEwV7i&password=pCQTy and see that cram tracks still work, but all the sequenceAdapters are removed from the config.json |
|
one goal, rather than just addressing this issue for bam/cram, is to make adapter available for other types of tracks such as rendering protein letters on genes |
cmdcolin
force-pushed
the
basetrack_add_sequenceadapter
branch
from
d927b87
to
dc14dca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.