Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Download as pdf..." missing glvis figures #22

Closed
rw-anderson opened this issue Aug 19, 2021 · 6 comments · Fixed by GLVis/glvis#186
Closed

"Download as pdf..." missing glvis figures #22

rw-anderson opened this issue Aug 19, 2021 · 6 comments · Fixed by GLVis/glvis#186
Assignees
Labels
notebook question Further information is requested

Comments

@rw-anderson
Copy link

rw-anderson commented Aug 19, 2021

I find these notebooks to be super useful for exploring algorithm alternatives. But since not everyone uses them or is even set up to use them, an export to pdf capability would be really useful for sharing results with others in a portable way. The notebooks do export to pdf, but the glvis windows just show up with the text "glvis()" in place of the figure.

Would it be feasible to export the figure in the pdf?

@tzanio
Copy link
Member

tzanio commented Aug 19, 2021

I agree that this will be awesome to support... @tomstitt and @kanye-quest, is it possibly related to #5?

@tzanio tzanio added enhancement New feature or request notebook labels Aug 19, 2021
@tomstitt
Copy link
Member

I think they are definitely related (being able to serialize the widget to a png or other format) but I thought someone like matplotlib would do this but they don't if you use the widget version:

Screen Shot 2021-08-19 at 8 29 55 AM

Regardless this is a good time to revisit screen shots so I'll look into that.

Also, here is a good discussion on the ideas, I think just aiming for a static image would be powerful

@tzanio
Copy link
Member

tzanio commented Aug 19, 2021

Wait... imagine glvis.js embedded in the file and you being able to interact with it in the PDF

🤯

@tzanio
Copy link
Member

tzanio commented Aug 24, 2021

Maybe I am missing something, but printing from Binder, worked for me: basic - Jupyter Notebook.pdf

@rw-anderson
Copy link
Author

No, I think it was I who was missing something - using the browser! I was trying to use the notebook export. But the browser print as pdf does exactly what I want.

@tzanio
Copy link
Member

tzanio commented Aug 24, 2021

Awesome! Can we close this then?

@tzanio tzanio self-assigned this Aug 24, 2021
@tzanio tzanio added question Further information is requested and removed enhancement New feature or request labels Aug 24, 2021
@tzanio tzanio closed this as completed Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
notebook question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants