Reduce use of AMsoil config at runtime #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SQLite access is serialized. Remove the SQLite call from an inner loop by caching the value of chrm.authority.
This is not the prettiest change. Instead of getting the authority from SQLite, get it from the SA. The SA already has it cached.
Cache the SQLite values and pass them along to the SubjectInvocation via the ABACGuard object. ABACGuard caches these values.
Cache the maintenance mode flag on the Handler base class. Add a method on the base class to deterimine if a maintenance outage is active. Use that in the method context instead of going through SQLite on every method invocation.
Skip SQLite and get the authority name via the SA handler.
Avoid SQLite by passing the authority into ensure_valid_urns.
In DatabaseEngine include the line required to log all SQLAlchemy activity. Leave it commented out so in the future it can be enabled on demand.
tcmitchell
added a commit
that referenced
this pull request
Nov 12, 2015
Reduce use of AMsoil config at runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AMsoil's config module accesses SQLite at runtime. SLQAlchemy serializes calls to SQLite so multiple clearinghouse calls interfere with each other when they need data from the config module. Some calls are intensive in their calls to the config module, like the lookup_projects call when looking up all projects.
Cache the data from the config module at startup time and use this cache at runtime. We do not expect that information to change during the run. Changes already require a restart so it's ok to cache the values at startup.