Validate requested expirations on create #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating a slice ensure that the expiration is in the future, but not more than the max expiration or the project expiration.
Only accept a valid date or null. Convert supplied dates to UTC and naive (i.e. timezone free). Raise an error if requested expiration is in the past.
tcmitchell
added a commit
that referenced
this pull request
Sep 2, 2015
Validate requested expirations on create
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating slices and projects, do a better job validating requested expirations. Raise an argument error if the expiration is in the past. Limit slice expiration to max renewal date. Convert expirations to UTC consistently. Do a better job filtering bad input for project expirations.
Fixes #413