Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Feature: Use of theme (MUI) and styled component for styling #134

Open
2 tasks done
sudhanshutech opened this issue Apr 5, 2023 · 6 comments
Open
2 tasks done
Labels
area/website issue or pr is for website component/react priority/moderate issue is medium priorities

Comments

@sudhanshutech
Copy link
Member

📜 Feature Description

Currently we are using inline style for styling so much which is not a good practice. We need to use themes property from mui using styled component.

🎤 Pitch

Create a style folder and under style folder create themes directory and using import ./style/themes assign theme/colors to the respective container,buttons or text. Use styled component for styling if there mui colors are not used

👀 Have you spent some time to check if this issue has been raised before?

  • I checked and didn't find similar issue

🔖 Have you read the Code of Conduct?

  • Yes, I have read Code of Conduct.
@sudhanshutech sudhanshutech added area/website issue or pr is for website component/react priority/moderate issue is medium priorities labels Apr 5, 2023
@HemanthPaila
Copy link
Contributor

Hey, @sudhanshutech I understand the problem. I will replace the inline CSS with the external CSS. I am interested to solve this. Could you please assign It to me?

@sudhanshutech
Copy link
Member Author

That's great to know @HemanthPaila , go ahead

@Yashsharma1911
Copy link
Member

@HemanthPaila you are constantly contributing to GDSC thinking to give you gdsc badge 😉

@HemanthPaila
Copy link
Contributor

Yah @Yashsharma1911. I am looking forward to solving bit more complex issues like routing setup, Redux (app-wide state management), and anything related to development. Thanks a lot.

@Yashsharma1911
Copy link
Member

Yah @Yashsharma1911. I am looking forward to solving bit more complex issues like routing setup, Redux (app-wide state management), and anything related to development. Thanks a lot.

Yes we will send you org invitation @ArunPatel02 please send org invitation to @HemanthPaila he is doing good work here we should appreciate it with GDSC tag in his profile 😎

@ArunPatel02
Copy link
Member

Yah @Yashsharma1911. I am looking forward to solving bit more complex issues like routing setup, Redux (app-wide state management), and anything related to development. Thanks a lot.

Yes we will send you org invitation @ArunPatel02 please send org invitation to @HemanthPaila he is doing good work here we should appreciate it with GDSC tag in his profile 😎

ok @Yashsharma1911

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/website issue or pr is for website component/react priority/moderate issue is medium priorities
Projects
None yet
Development

No branches or pull requests

4 participants