-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Springboot quickstart web #2491
Conversation
…-edit Spring Boot Quickstart language edit
# Conflicts: # astro/src/content/quickstarts/quickstart-springboot-web.mdx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am getting an error when trying to run the
./mvnw package
I can't go further until I get this resolved. Any ideas?
|
||
We have already done this for you in the example repository, but if you wish to do so yourself you can go to the Initializr site at https://start.spring.io/ and download your own starter package. We will rely on three dependencies for this project: | ||
You can unzip the package in any directory you would like to. This guide assumes you are in `stub-application` in the example repository, so you should substitute any references to that directory with the directory you unzipped the files in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a big deal to change from stub-application
to your-application? We have done a few of these now and generally use
your-application`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made the requested change in the PR here FusionAuth/fusionauth-quickstart-java-springboot-web#1
Co-authored-by: Mark Robustelli <[email protected]>
# Conflicts: # astro/src/components/quickstarts/springboot-prereqs.mdx # astro/src/content/quickstarts/quickstart-springboot-web.mdx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was able to get it to run. Looking good.
Co-authored-by: Mark Robustelli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was some missing code and things don't seem to be lining up. Please make the requested changes, run through the quickstart to verify every step works and then re-request review. As things stand, my current implementation ends up with a your-application
directory inside of another your-applicaiton
directory and it does not run. I get the following errors.
INFO] Compiling 7 source files to /Users/mark.robustelli/Projects/quickstart-springboot/quickstart-springboot-web/fusionauth-quickstart-springboot-web/your-application/target/classes [INFO] ------------------------------------------------------------- [ERROR] COMPILATION ERROR : [INFO] ------------------------------------------------------------- [ERROR] /Users/mark.robustelli/Projects/quickstart-springboot/quickstart-springboot-web/fusionauth-quickstart-springboot-web/your-application/src/main/java/io/fusionauth/quickstart/springweb/AccountController.java:[3,52] package org.springframework.security.core.annotation does not exist [ERROR] /Users/mark.robustelli/Projects/quickstart-springboot/quickstart-springboot-web/fusionauth-quickstart-springboot-web/your-application/src/main/java/io/fusionauth/quickstart/springweb/AccountController.java:[4,58] package org.springframework.security.oauth2.core.oidc.user does not exist [ERROR] /Users/mark.robustelli/Projects/quickstart-springboot/quickstart-springboot-web/fusionauth-quickstart-springboot-web/your-application/src/main/java/io/fusionauth/quickstart/springweb/AccountController.java:[7,47] package org.springframework.web.bind.annotation does not exist [ERROR] /Users/mark.robustelli/Projects/quickstart-springboot/quickstart-springboot-web/fusionauth-quickstart-springboot-web/your-application/src/main/java/io/fusionauth/quickstart/springweb/AccountController.java:[13,66] cannot find symbol symbol: class OidcUser location: class io.fusionauth.quickstart.springweb.AccountController [ERROR] /Users/mark.robustelli/Projects/quickstart-springboot/quickstart-springboot-web/fusionauth-quickstart-springboot-web/your-application/src/main/java/io/fusionauth/quickstart/springweb/HomeController.java:[6,47] package org.springframework.web.bind.annotation does not exist ......
Co-authored-by: Mark Robustelli <[email protected]>
* Packaging - `Jar` | ||
* Java Version - `17` | ||
|
||
This project has the following three dependencies which you will need to add by clicking the "Add Dependencies" button when creating the package on the Initializr site. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mark-robustelli can you confirm if you added these dependencies. The error log you posted shows that the package that you downloaded on the Initializr site does not have the three dependencies listed in the text here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for all the hard work. I did miss the section on adding the dependencies. I have gone through it all now and looks good. Please add a section to the troubleshooting that says something to the effect if you have to create the static directory (or) others then you probably missed adding the dependencies section. After that, I am all good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry a few more.
- Please add the "note" to run from complete directory if desired
- I asked to move the note about running from
your-directory
up as well since we added commands. - The last thing is the logout is not working for me. It just keeps taking me to the
logout
page. Please fix to take to home page and request re-review.
Thanks.
|
||
- OAuth2 Client | ||
- Thymeleaf | ||
- Spring Web | ||
|
||
This example was made with `Maven`, Spring Boot version `2.7.12`, and Java 17. If you choose different options the configuration and code may be different. | ||
If you choose different options, the configuration and code may be different. After entering the configuration settings above and adding the dependencies you can click the <Uielement label="Generate"/> button to download your starter package. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The note to run all command from the your-application should be moved to here.
Co-authored-by: Mark Robustelli <[email protected]>
I already fixed this issue in a previous PR to the example repository. Can you make sure the kickstart reruns by removing the cached volumes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the hard work! LGTM. @mooreds ready for your review
Closing under #2580 |
Also a small change to the example repo in FusionAuth/fusionauth-quickstart-java-springboot-web#1