-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
English messages.properties inconsistencies #2251
Comments
All localized versions are managed via https://github.com/FusionAuth/fusionauth-localization. If there are issues with any of them, please open a PR against that repo for a correction. |
FYI @robotdan @Aaron-Ritter and team are doing some work on that repo, but we're tracking all of the Sonderformat work via issues here so they have one place to look. That's what this issue is all about. |
Will start labeling these types of issues with |
@mooreds this issue has all the related pull requests created and is ready for review. With the exception of "Public and shared device" which is a very minor detail we found and we are not sure if it needs changing. |
Inconsistencies and possible issues found in messages.properties
There are a few inconsistencies and possible issues I found in messages.properties while working on the German translation.
Parent and Legal guardian messages
At the moment the messages are inconsistent, I think all of these lines should be updated to "your parent or legal guardian".
Return to login messages
There are two properties which have as a value "Return to Login" where
back-to-login
I couldn't find referenced in any of the templates onlyreturn-to-login
is used. In addition there is one property link textreturn-to-normal-login
containing "Return to the normal login" which isn't "Return to normal login" mentioned inwebauthn-reauth-return-to-login
.Based on that I have two questions is "Return to normal login" in
webauthn-reauth-return-to-login
referencingreturn-to-normal-login
and if so which one should be updated. In addition to that, if one message value contains another message property shouldn't the property be linked instead of hardcoded as it can cause inconsistencies?Non-alphanumeric character vs special character
In German it is more common to use special character than non-alphanumeric character, isn't that true for English?
Public and shared device
To avoid user error (not reading the whole sentence) and enforce a securer user behavior it might be better to start with, in which case not to do something rather than the other way around.
Contact Support
It would make sense to standardize the message of contacting administrator or support.
SMS 2FA Message
Phone number formats depend heavily on the country, especially with services where you have users from multiple countries you wont get the format right and therefore we would suggest to rephrase it excluding the number format all together.
Grammatical errors
There are a few Grammatical errors to correct.
The text was updated successfully, but these errors were encountered: