Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding in Type support for standardized prop interfaces #72

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

iryanclarke
Copy link
Collaborator

Adds in essentially what we already have within hw-admin for our shared interfaces, and also adds in the typing for individual profiles themselves (aka primary, and info)

Does all of these additions make sense?

@CCAyl
Copy link
Contributor

CCAyl commented Aug 25, 2022

i was wondering if we need to still have these typed out, i'm assuming the profile mapper was also giving you heck?

@CCAyl
Copy link
Contributor

CCAyl commented Aug 25, 2022

i guess we also just need to this move over our colour prop types

@iryanclarke
Copy link
Collaborator Author

i was wondering if we need to still have these typed out, i'm assuming the profile mapper was also giving you heck?

The profile mapper is working great! I mostly need the typing for the individual color profiles like primary so I can properly type the mapping style functions, similar to how we currently have them:

const colorProfileStyles => (selectedColor: colorTheme) => css`
     color: ${selectedColor.base};
     background-color: ${selectedColor.backgroundMuted};
`

@CCAyl
Copy link
Contributor

CCAyl commented Aug 26, 2022

if mapper is working great for you i have other questions, because mine completely blew up storybook lol

Copy link
Collaborator

@alexandra-lim alexandra-lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if mapper is working great for you i have other questions, because mine completely blew up storybook lol

Yeah Cath and I were looking at mapper yesterday and couldn't figure it out. Can you link us to an MR you've implemented it in?

@iryanclarke iryanclarke merged commit 464bb56 into main Aug 26, 2022
@iryanclarke iryanclarke deleted the aviary-token-typing branch August 30, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants