chore: remove uwuify feature
#6698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #6698 will not alter performanceComparing Summary
|
kayagokalp
force-pushed
the
kayagokalp/remove_uwuify
branch
from
0cfde7f
to
8c3ca4a
Compare
tritao
approved these changes
Nov 6, 2024
JoshuaBatty
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based on #6696 and blocked until it merges.
closes #6697.
This PR removes
uwuifyfeature and the dependency onuwuifycrate. The motivation behind this PR is basically consisted of two main areas:uwuifyfeature is only x86, causing straightforwardcargo build --all-targetsto fail on arm machines.uwuifyis not maintained and contains also unmaintained dependencies.I don't think this is something critical to justify having the downsides and propose we remove it.