Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: move to buildjet #6656

Merged
merged 2 commits into from
Oct 21, 2024
Merged

ci: move to buildjet #6656

merged 2 commits into from
Oct 21, 2024

Conversation

kayagokalp
Copy link
Member

@kayagokalp kayagokalp commented Oct 17, 2024

Description

Moves CI runners to buildjet from github.

Benchmarks

before after
total 6823 4815
slowest 1004 717

Overall, %30 faster CI times, ~5 minutes removed for each PR in slowest run (e2e testing).

@kayagokalp kayagokalp self-assigned this Oct 17, 2024
@kayagokalp kayagokalp added enhancement New feature or request ci labels Oct 17, 2024
@kayagokalp kayagokalp marked this pull request as ready for review October 17, 2024 23:42
@kayagokalp kayagokalp requested a review from a team as a code owner October 17, 2024 23:42
@kayagokalp kayagokalp requested review from a team October 17, 2024 23:42
@IGI-111
Copy link
Contributor

IGI-111 commented Oct 17, 2024

As I recall, we kept the standard runners on because the buildjet ones are more expensive. I think we should have a discussion about cost here.

@kayagokalp
Copy link
Member Author

As I recall, we kept the standard runners on because the buildjet ones are more expensive. I think we should have a discussion about cost here.

Sure, the calculation below was my reasoning of opening this PR:

As far as I can see, buildjet runner I used here costs $0.008 / min

And cheapest x86 github runner is also $0.008/min.
image

That being said I think we have some CI minutes included in our github enterprise subscription, so not sure which makes more sense taking that account

cc @Voxelot

@byucesoy
Copy link

Hey folks,

Sorry for jumping in, but I saw this thread and wanted to chime in. Did you see Ubicloud runners? They are fully compatible with Github runners and 10x cheaper. You can for example pick a bigger runner, which would be faster (if the bottleneck is on CPU, memory or disk IO) and cheaper at the same time.

Disclaimer: I'm Ubicloud employee. Feel free to ask any questions you might have.

Copy link
Member

@sdankel sdankel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Voxelot
Copy link
Member

Voxelot commented Oct 21, 2024

The buildjet to github runner price comparison isn't apples to apples. While the prices are the same at the low tier, the buildjet runner is 2x the machine. On the whole build-jet is at least 2x cheaper than github when comparing similar runner specs.

We have a lot of minutes included in the enterprise plan, but those are only for the 2-core runners. I value the productivity of the team's CI cycles more than getting freebie minutes on slow machines.

@kayagokalp kayagokalp merged commit 79170db into master Oct 21, 2024
38 checks passed
@kayagokalp kayagokalp deleted the kayagokalp/buildjet branch October 21, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants