Add AST module caching support to the LSP. #4988
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
I've taken these commits and added them into #5251. Closing this in favour of that PR. |
JoshuaBatty
added a commit
that referenced
this pull request
Nov 10, 2023
## Description This PR supersedes #4988 and builds on backend work done by @tritao in #4733. A new `ModuleId` is created for each compiled module. The `SourceId` type now also stores the `ModuleId` that was used to create it. This allows us to perform garbage collection on types in the Declaration and Type engines that refer the provided module. ```rust if let Some(module_id) = engines.se().get_module_id(&path) { engines.clear_module(&module_id); } ``` This method isn't super cheap to call. My tests had this averaging at 54ms. We are currently performing garbage collection on every key stroke in LSP. We should look to have another metric such as only clearing once every 20 keystrokes or so in the future. I ran benchmarking on recompiling the `doc_comments` example 20 times to simulate rapid keystrokes during coding. Here are the results. | Without Caching | With Caching | |---------------------|------------------| | 89.489 s | 4.6236 s | A speed up of 1835.49% is certainly great, yet 4.6 seconds still sounds like an eternity. Still have lots of room to improve but this should improve our current system dramatically. closes #4994 Co-authored-by: Joao Matos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds AST module caching support to the LSP.
Checklist
Breaking*orNew Featurelabels where relevant.