Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit build_tests to improve interface and remove clones #5620

Open
sdankel opened this issue Feb 16, 2024 · 0 comments
Open

Revisit build_tests to improve interface and remove clones #5620

sdankel opened this issue Feb 16, 2024 · 0 comments
Labels
forc-debug Everything related to forc-debug forc-pkg Everything related to the `forc-pkg` crate.

Comments

@sdankel
Copy link
Member

sdankel commented Feb 16, 2024 

          Also we should visit this function some time later because cloning `BuiltPackage` is a costly event that might lead to huge memory usage stuff that we encountered before. I think we should be fine for now but maybe in a separate PR that refactors `forc-pkg` as mentioned above, we can try to remove all/some clone's on built package's across the repo.

Originally posted by @kayagokalp in #5477 (comment)
@sdankel sdankel added forc-pkg Everything related to the `forc-pkg` crate. forc-debug Everything related to forc-debug labels Feb 16, 2024
@sdankel sdankel assigned sdankel and unassigned sdankel Feb 16, 2024
@sdankel sdankel mentioned this issue Feb 16, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
forc-debug Everything related to forc-debug forc-pkg Everything related to the `forc-pkg` crate.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sdankel