Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ec_recover to ec_recover_k1 #5219

Open
Braqzen opened this issue Oct 23, 2023 · 3 comments
Open

Rename ec_recover to ec_recover_k1 #5219

Braqzen opened this issue Oct 23, 2023 · 3 comments
Labels
breaking May cause existing user code to break. Requires a minor or major release. lib: std Standard library

Comments

@Braqzen
Copy link
Contributor

Braqzen commented Oct 23, 2023

With the introduction of #5133 we have some new recovery functionality.

There are 2 related opcodes, erc1 & eck1. For consistency we should rename ec_recover to be explicit similar to the new r1 function.
@Braqzen Braqzen added lib: std Standard library breaking May cause existing user code to break. Requires a minor or major release. labels Oct 23, 2023
@Braqzen
Copy link
Contributor Author

Braqzen commented Oct 23, 2023

Thoughts cc @bitzoic ?
I'm happy to make the changes.

@bitzoic
Copy link
Member

bitzoic commented Oct 24, 2023

No, erc1 is the default and is used in the Fuel ecosystem. erk1 should only be used under special circumstances, this was left as is intentionally.

@Braqzen
Copy link
Contributor Author

Braqzen commented Oct 24, 2023

No, erc1 is the default and is used in the Fuel ecosystem. erk1 should only be used under special circumstances, this was left as is intentionally.

This has nothing to do with defaults. It's about distinguishing between the recovery

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking May cause existing user code to break. Requires a minor or major release. lib: std Standard library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bitzoic @Braqzen