Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LSP shouldn't recompile when moving between rust files in the users workspace #5031

Closed
JoshuaBatty opened this issue Aug 25, 2023 · 0 comments · Fixed by #5032
Closed

LSP shouldn't recompile when moving between rust files in the users workspace #5031

JoshuaBatty opened this issue Aug 25, 2023 · 0 comments · Fixed by #5032
Assignees
@JoshuaBatty
Labels
language server LSP server

Comments

@JoshuaBatty
Copy link
Member

Just noticed that the language server recompiles the whole workspace when a new file is opened in the users workspace. As nothing has changed we shouldn't need to recompile here as the whole workspace has already been compiled and traversed.
@JoshuaBatty JoshuaBatty self-assigned this Aug 25, 2023
@JoshuaBatty JoshuaBatty added the language server LSP server label Aug 25, 2023
@JoshuaBatty JoshuaBatty mentioned this issue Aug 25, 2023
Merged
7 tasks
JoshuaBatty added a commit that referenced this issue Aug 25, 2023
@JoshuaBatty
LSP: Don't recompile workspace when moving between files (#5032)
15e0ec4 
## Description
We have been unnecessarily recompiling the whole workspace when a user
moves between different files. As the whole workspace is already
compiled and traversed this was hugely unnecessary. Feels so much nicer
moving between files now.

closes #5031

## Checklist

- [x] I have linked to any relevant issues.
- [x] I have commented my code, particularly in hard-to-understand
areas.
- [ ] I have updated the documentation where relevant (API docs, the
reference, and the Sway book).
- [ ] I have added tests that prove my fix is effective or that my
feature works.
- [ ] I have added (or requested a maintainer to add) the necessary
`Breaking*` or `New Feature` labels where relevant.
- [ ] I have done my best to ensure that my PR adheres to [the Fuel Labs
Code Review
Standards](https://github.com/FuelLabs/rfcs/blob/master/text/code-standards/external-contributors.md).
- [ ] I have requested a review from the relevant team or maintainers.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JoshuaBatty JoshuaBatty

Labels
language server LSP server
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

LSP: Don't recompile workspace when moving between files FuelLabs/sway
1 participant
@JoshuaBatty