You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Our E2E test suite separates tests into two directories: should_fail and should_pass. IIRC we were using these directories to determine what to expect, but we now do that with test.tomls and it doesn't really matter which directory a test sits in.
My suggestion is that we should not organize tests in this way. If you are working on a feature, all tests, failing or not, should be in the same directory.
I considered this when introducing the test.toml testing, but it would've been too big a diff to do it then. But I agree, we really don't need to organise based on the test type, but rather what it is actually testing.
Our E2E test suite separates tests into two directories:
should_fail
andshould_pass
. IIRC we were using these directories to determine what to expect, but we now do that withtest.toml
s and it doesn't really matter which directory a test sits in.My suggestion is that we should not organize tests in this way. If you are working on a feature, all tests, failing or not, should be in the same directory.
So now it looks like:
And my suggestion is:
The text was updated successfully, but these errors were encountered: