Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the should_fail/should_pass separation in E2E tests #2690

Open
AlicanC opened this issue Sep 1, 2022 · 1 comment
Open

Remove the should_fail/should_pass separation in E2E tests #2690

AlicanC opened this issue Sep 1, 2022 · 1 comment
Assignees
Labels
testing General testing

Comments

@AlicanC
Copy link
Contributor

AlicanC commented Sep 1, 2022

Our E2E test suite separates tests into two directories: should_fail and should_pass. IIRC we were using these directories to determine what to expect, but we now do that with test.tomls and it doesn't really matter which directory a test sits in.

My suggestion is that we should not organize tests in this way. If you are working on a feature, all tests, failing or not, should be in the same directory.

So now it looks like:

test/src/e2e_vm_tests/test_programs/should_pass/passing_test_for_feature_a
test/src/e2e_vm_tests/test_programs/should_fail/failing_test_for_feature_a

And my suggestion is:

test/src/e2e_vm_tests/test_programs/feature_a/passing_test
test/src/e2e_vm_tests/test_programs/feature_a/failing_test
@AlicanC AlicanC added the testing General testing label Sep 1, 2022
@otrho
Copy link
Contributor

otrho commented Sep 2, 2022

I considered this when introducing the test.toml testing, but it would've been too big a diff to do it then. But I agree, we really don't need to organise based on the test type, but rather what it is actually testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing General testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants