Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New storage keyword highlighting applies highlighting when importing modules #63

Closed
Braqzen opened this issue Jun 17, 2022 · 3 comments
Closed
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Braqzen
Copy link

Braqzen commented Jun 17, 2022

Summary

Personally, I'm not a fan of the colour at all but I can try to ignore that - pls change it to be light grey or green or something.
What I cannot ignore is that storage is highlighted in more places than it should be highlighted e.g. when you declare storage for a contract to use.
Specifically, storage being individually highlighted when you import modules from std.
The highlighting applies as you'd expect it when using it in functions.

Screenshot

1

@Braqzen Braqzen added bug Something isn't working good first issue Good for newcomers labels Jun 17, 2022
@adlerjohn adlerjohn moved this to Todo in Fuel Network Jun 17, 2022
@adlerjohn
Copy link
Contributor

adlerjohn commented Jun 17, 2022

This is because storage is a keyword, so it's naively highlighted. This brings up a good question, of whether or not it should be forbidden for a library to be called storage. If yes, then this issue will magically go away.

@adlerjohn
Copy link
Contributor

Related: FuelLabs/sway#1996

@sdankel
Copy link
Member

sdankel commented Aug 23, 2022

Fixed in #80

image

@sdankel sdankel closed this as completed Aug 23, 2022
Repository owner moved this from Todo to Done in Fuel Network Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
Archived in project
Development

No branches or pull requests

3 participants