Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add full abi coder tests #3349

Open
wants to merge 66 commits into
base: master
Choose a base branch
from
Open

chore: add full abi coder tests #3349

wants to merge 66 commits into from
+4,560 −0

Conversation

petertonysmith94
Copy link
Contributor

@petertonysmith94 petertonysmith94 commented Oct 21, 2024 •
edited
Loading

Summary

  • We have added a fully featured contract (abi-contract) that takes fixed inputs and returns an expected value.
    • As @nedsalk mentioned, Sway performs some precompilation.
  • We have implemented tests for each of the contract functions, and we are currently using our existing encoding package, @fuel-ts/abi-coder.
    • This setup will enable us to swap out the Interface for our newly refactored package with complete confidence and no risk of regression.
  • I have introduced a new custom Vitest matcher, toEqualBn, to simplify the validation of returned BN values.

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

petertonysmith94 and others added 30 commits October 3, 2024 19:26
@petertonysmith94
chore: added tests around all abi-contract tests
6b23067
@petertonysmith94
chore: changeset
b000281
@Torres-ssf
fix Eq for ExternalEnum
96a74ea
@Torres-ssf
fix equals use
0932fd6
@Torres-ssf
linting
d91f6fc
@Torres-ssf
minor fixes within contract code
801c02d
@Torres-ssf
fix comparison at types_value_then_value_then_void_then_void
d8b58e5
@Torres-ssf
implementing missing Eq
f6f6cd4
@Torres-ssf
using let for heap types
54af3cc
@Torres-ssf
rename vec_32_from
fa6e12a
@Torres-ssf
rename some functions
e2cb4cc
@Torres-ssf
rename types_option_geo
33dd29d
@Torres-ssf
type_struct_external
15453dc
@Torres-ssf
rename contract abi
dd7108d
@Torres-ssf
fix test case types_enum_external
b2df95f
@Torres-ssf
implement Eqs related to types_struct_with_implicit_generics fn
fba792f
@Torres-ssf
implementing types_struct_with_implicit_generics
f0cd0ed
@Torres-ssf
add test for types_struct_with_implicit_generics
7687b3a
@Torres-ssf
unskip test
6de8b99
@Torres-ssf
use let instead of const to avoid run-time compile error
767821b
@Torres-ssf
fixing some tests
2dd95c5
@Torres-ssf
fix multi_arg_b256_bool fn and its test
cbd8b13
@Torres-ssf
unskip multi_arg_vector_vector
f8e8d7a
@Torres-ssf
unskip multi_arg_vector_b256
18ffc35
@Torres-ssf
unskip multi_arg_struct_vector
d9b30d2
@Torres-ssf
implement multi_arg_u64_struct
23385f0
@Torres-ssf
add test for multi_arg_u64_struct
f54a2a2
@Torres-ssf
implement multi_arg_str_str
84ae89c
@Torres-ssf
add test for multi_arg_str_str
978ad9b
@Torres-ssf
implement Eq for Vec<u64>
411ca8f
@petertonysmith94 petertonysmith94 dismissed Torres-ssf’s stale review November 19, 2024 16:57

Addressed the requested changes

Torres-ssf
Torres-ssf previously approved these changes Nov 21, 2024
View reviewed changes
danielbate
danielbate reviewed Nov 22, 2024
View reviewed changes
Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woah, great work! Few comments

packages/fuel-gauge/src/abi/vitest.matcher.ts Show resolved Hide resolved
packages/fuel-gauge/test/fixtures/forc-projects/abi-contract/src/data_structures.sw
Comment on lines +107 to +108
// propC4: Vec<StructD<u16, u16, StructF<bool>>>,
// propC5: Vec<StructD<u32, u32, StructF<Vec<StructG>>>>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for leaving

packages/fuel-gauge/src/abi/abi-coder.test.ts Show resolved Hide resolved
packages/fuel-gauge/src/abi/abi-coder.test.ts Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

Coverage Report:

Lines Branches Functions Statements
64.12%(+0%) 69.69%(+0.03%) 72.66%(+0%) 64.56%(+0%)
Changed Files:
Ok File (✨=New File) Lines Branches Functions Statements
🔴 packages/account/src/providers/transaction-request/transaction-request.ts 88.57%
(+0%)		 78.08%
(+1.37%)		 84%
(+0%)		 88.81%
(+0%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedsalk nedsalk nedsalk approved these changes

@danielbate danielbate danielbate approved these changes

@Torres-ssf Torres-ssf Torres-ssf left review comments

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@arboleya arboleya Awaiting requested review from arboleya arboleya is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@maschad maschad Awaiting requested review from maschad maschad is a code owner

At least 3 approving reviews are required to merge this pull request.

Assignees

@petertonysmith94 petertonysmith94

@Torres-ssf Torres-ssf

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@petertonysmith94 @Torres-ssf @danielbate @nedsalk @maschad