Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecate all receipt coders #3106

Merged
merged 15 commits into from
Sep 6, 2024
Merged

chore: deprecate all receipt coders #3106

merged 15 commits into from
Sep 6, 2024

Conversation

Torres-ssf
Copy link
Contributor

@Torres-ssf Torres-ssf commented Sep 4, 2024 •
edited
Loading

Release notes

In this release, we:

  • Deprecate all receipt coders

Checklist

  • All changes are covered by tests (or not applicable)
  • All changes are documented (or not applicable)
  • I reviewed the entire PR myself (preferably, on GH UI)
  • I described all Breaking Changes (or there's none)

@Torres-ssf Torres-ssf added the chore Issue is a chore label Sep 4, 2024
@Torres-ssf Torres-ssf self-assigned this Sep 4, 2024
@vercel Vercel
Copy link

vercel bot commented Sep 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
create-fuels-template ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 0:22am
ts-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 6, 2024 0:22am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
create-fuels-counter-example ⬜️ Ignored (Inspect) Sep 6, 2024 0:22am

Dhaiwat10
Dhaiwat10 previously approved these changes Sep 5, 2024
View reviewed changes
danielbate
danielbate reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@danielbate danielbate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment around potential breaking change.

.changeset/olive-apples-brush.md Show resolved Hide resolved
@arboleya arboleya mentioned this pull request Sep 5, 2024
Closed
@Torres-ssf Torres-ssf marked this pull request as draft September 6, 2024 12:03
@Torres-ssf Torres-ssf changed the title chore: remove all receipt coders chore: deprecate all receipt coders Sep 6, 2024
@Torres-ssf Torres-ssf marked this pull request as ready for review September 6, 2024 12:18
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 6, 2024

Coverage Report:

Lines Branches Functions Statements
79.37%(+0%) 72.15%(+0%) 77.73%(+0%) 79.43%(+0%)
Changed Files:

Coverage values did not change👌.

@Torres-ssf Torres-ssf enabled auto-merge (squash) September 6, 2024 15:00
@Torres-ssf Torres-ssf merged commit 37eab14 into master Sep 6, 2024
27 of 28 checks passed
@Torres-ssf Torres-ssf deleted the st/chore/remove-receipts-coders branch September 6, 2024 17:14
@maschad maschad mentioned this pull request Sep 18, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nedsalk nedsalk nedsalk approved these changes

@maschad maschad maschad approved these changes

@arboleya arboleya arboleya approved these changes

@digorithm digorithm Awaiting requested review from digorithm digorithm is a code owner

@petertonysmith94 petertonysmith94 Awaiting requested review from petertonysmith94 petertonysmith94 is a code owner

@Dhaiwat10 Dhaiwat10 Awaiting requested review from Dhaiwat10 Dhaiwat10 is a code owner

@danielbate danielbate Awaiting requested review from danielbate danielbate is a code owner

Assignees

@Torres-ssf Torres-ssf

Labels
chore Issue is a chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate Receipt Coders
7 participants
@Torres-ssf @arboleya @danielbate @maschad @petertonysmith94 @nedsalk @Dhaiwat10