fix: broken unpublish workflow #2365
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dhaiwat10
requested review from
digorithm,
arboleya,
Torres-ssf,
danielbate,
nedsalk,
petertonysmith94 and
maschad
as code owners
|
Coverage Report:
Changed Files:Coverage values did not change👌. |
maschad
reviewed
May 21, 2024
| @@ -15,7 +15,7 @@ concurrency: | |||
| jobs: | |||
| clean-npm-versions: | |||
| name: Unpublish versions next and pr | |||
| runs-on: buildjet-4vcpu-ubuntu-2204 | |||
There was a problem hiding this comment.
@danielbate what was the impetus for running on this specific hardware?
There was a problem hiding this comment.
I believe it was lifted from the frontend codebases (e.g. fuel-connectors)
There was a problem hiding this comment.
This hardware should be superior and have higher availability.
Why are we rolling this config back?
|
This job didn't actually succeed. I think it'll be worth refactoring |
|
Marking as a draft until we are sure about the script itself |
|
Closing in favour of issue #2377 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The workflow responsible for unpublishing old versions/tags from npm was broken.
This PR fixes that.
Successful run on this branch: https://github.com/FuelLabs/fuels-ts/actions/runs/9179019639/job/25240208986