Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpublish NPM versions #2377

Closed
petertonysmith94 opened this issue May 23, 2024 · 7 comments
Closed

Unpublish NPM versions #2377

petertonysmith94 opened this issue May 23, 2024 · 7 comments
Assignees
Labels
chore Issue is a chore

Comments

@petertonysmith94
Copy link
Contributor

petertonysmith94 commented May 23, 2024

Summary

Work was carried out to improve the functionality around unpublishing package versions (#2495):

  • Allow the passing of a particular version.
  • Show a more appropriate message on dry runs.

Due to issues with our package hierarchy (outlined here), we couldn't unpublish these versions automatically. Once we have migrated to a single fuels package (#2493), we should revisit this functionality to see if unpublishing is possible.

After we can confirm this functionality, we should contact support to clean up old NPM versions that are more than 72 hours old.


@petertonysmith94
Copy link
Contributor Author

It looks like unpublishing is unreliable/does not work for our use-case.

TL;DR:
As we have many packages, all dependant upon one another, I believe we fail to meet the conditions outlined here.

Less than 72 hours ago

I was unsuccessful in unpublishing with the version 0.0.0-pr-2543-20240618113822 which was published < 30 minutes.

More than 72 hours ago

I believe we could contact support to clean up old NPM versions. We could do this once we migrate to a single package fuels package (#2493), so we have minimal dependants.

@petertonysmith94
Copy link
Contributor Author

I believe we should stop publishing (to NPM) on every E2E test.

Looking over possible solutions:

  • We could publish to a local registry using local-npm within the CI.
  • Separate our testing packages (fuels-beta) from our official packages (fuels). Potentially this could be private.

Any thoughts @arboleya?

@arboleya arboleya added p2 and removed p0 labels Jun 18, 2024
@arboleya
Copy link
Member

Yes, let's do that and stop publishing PRs automatically.

When we merge a PR to master, we publish an update to the next tag.

We could move our npm installs fuels@next checks to happen at this point.

This way, we can stop publishing PRs while keeping the validation.

@petertonysmith94
Copy link
Contributor Author

That's a better solution!

@petertonysmith94
Copy link
Contributor Author

Yes, let's do that and stop publishing PRs automatically.

When we merge a PR to master, we publish an update to the next tag.

We could move our npm installs fuels@next checks to happen at this point.

This way, we can stop publishing PRs while keeping the validation.

I've implemented this in #2489.

What do you think about contacting support for cleaning up our old versions?
Happy to create a list of the versions that need cleaning.

Otherwise - is it worth updating the description and changing priority?

@arboleya
Copy link
Member

Considering the CDN thing was addressed, should we close this?

@petertonysmith94
Copy link
Contributor Author

@arboleya I think given the constraints that NPM has, we won't be able to unpublished until #2493 is concluded. For that reason, I'll close this until we have that resolved, then can could potentially revisit this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Issue is a chore
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants