Skip to content
This repository has been archived by the owner on Oct 25, 2024. It is now read-only.

Cleanup sqlite query usage #347

Closed
ra0x3 opened this issue Nov 20, 2022 · 0 comments · Fixed by #363
Closed

Cleanup sqlite query usage #347

ra0x3 opened this issue Nov 20, 2022 · 0 comments · Fixed by #363
Assignees
Labels
good first issue Good for newcomers

Comments

@ra0x3
Copy link
Contributor

ra0x3 commented Nov 20, 2022

  • When writing SQLite queries we return a SqliteRow from the query and extract each field in the query out manually row.get(index);
  • We didn't have to do this in Postgres because type inference was supported with Postgres
  • Now that Fix sqlite update return and order by type inference launchbadge/sqlx#1960 has landed we should update SQLite queries to remove this temporary/manual type inference functionality
@ra0x3 ra0x3 added good first issue Good for newcomers code quality labels Nov 20, 2022
@ra0x3 ra0x3 moved this to Todo in Fuel Network Nov 20, 2022
@deekerno deekerno self-assigned this Nov 28, 2022
Repository owner moved this from Todo to Done in Fuel Network Nov 28, 2022
@ra0x3 ra0x3 removed this from Fuel Network Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants