Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port number is duplicated on absolute path generation with non-standard ports #379

Closed
robertosanval opened this issue Feb 26, 2020 · 7 comments

Comments

@robertosanval
Copy link

I've discovered a weird problem.

When I use non-standard ports on my local dev server the generated URLs duplicates the port.

This is the code:

url = Routing.generate('style_new', { 'id': id }, true);
console.log(url);

I get this URL:
https://localhost:4443:4443/admin/style/new/5

@pierre-H
Copy link

same problem

@YoannChabert
Copy link

YoannChabert commented Mar 1, 2020

Maybe its the same problem as #377 ?

Check the version of symfony/serializer (version 5.0.5 have issues for me, not 5.0.4)

@pierre-H @robertosanval

@robertosanval
Copy link
Author

Thanks @YoannChabert but I'm using symfony/serializer 4.4.0

@YoannChabert
Copy link

I don't know if that can help, but i tried again the version 5.0.5 and it works !
But I also deleted all the content of bundles/* in my Symfony Project.
Have you tried this ? @robertosanval

@ViniTou
Copy link

ViniTou commented Mar 18, 2020

If there is an option this bug was introduced here? As i see that setting absolute to true is what kinda triggers it.
as I have same bug on serializer 5.0.5 and 5.0.4.
https://github.com/FriendsOfSymfony/FOSJsRoutingBundle/pull/361/files
@YoannChabert
@robertosanval

@wadjeroudi
Copy link

@ViniTou I think you're right about this PR, I had to downgrade to fos js routing bundle to ~2.4.0.

@robertosanval
Copy link
Author

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants