Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing snippets from store plugin #392

Closed
nussjustin-hmmh opened this issue Jul 25, 2024 · 0 comments
Closed

Missing snippets from store plugin #392

nussjustin-hmmh opened this issue Jul 25, 2024 · 0 comments

Comments

@nussjustin-hmmh
Copy link
Contributor

nussjustin-hmmh commented Jul 25, 2024

PHP Version

8.3.9

Shopware Version

6.6.4.0

Plugin Version

store.shopware.com/netinexteasycoupondesigns 6.0.0

Actual behaviour

Snippets defined in src/Resources/app/administration/src/component/toulousi/i18n are missing and show the non-replaced snippet identifiers (e.g. ``)

This happens because shopware-cli removes the JSON files during the project ci command.

The files are normally read by the SnippetFinder and returned by the /api/_admin/snippets endpoint, but since they got removed, and were not included in the JS directly, the translation is missing.

The problem does not reproduce with the following .shopware-project.yml:

build:
    keep_extension_source: true

Or when running just project admin-build or project admin-watch.

Expected behaviour

Not completely sure.

Part of me wants to say that because it works when not "optimizing away" source files, it should still work.

On the other hand, the files are not imported / registered directly in the JS.

Steps to Reproduce?

Install the store.shopware.com/netinexteasycoupon and store.shopware.com/netinexteasycoupondesign plugins and run run the project ci command.

After that go to the administration (Marketing > EasyCoupon), choose "Designs" in the left sidebar, create/edit a design, choose the "Variants" tab and click on the "Open designer" button.

@shyim shyim closed this as completed in 69893a9 Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant