Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Reusable Util for Opening OAuth Popup #83

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Create Reusable Util for Opening OAuth Popup #83

merged 4 commits into from
Oct 29, 2024

Conversation

DavideIadeluca
Copy link
Member

Fixes #0000

Changes proposed in this pull request:

Reviewers should focus on:

Screenshot

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

Required changes:

@DavideIadeluca DavideIadeluca self-assigned this Oct 29, 2024
@DavideIadeluca DavideIadeluca added the enhancement New feature or request label Oct 29, 2024
@DavideIadeluca DavideIadeluca marked this pull request as ready for review October 29, 2024 07:58
imorland
imorland requested changes Oct 29, 2024
View reviewed changes
Copy link
Member

@imorland imorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a great addition, just a couple of small comments :)

js/src/forum/utils/popupUtils.ts Outdated Show resolved Hide resolved
js/src/forum/utils/popupUtils.ts Outdated Show resolved Hide resolved
js/src/forum/utils/popupUtils.ts Outdated Show resolved Hide resolved
@DavideIadeluca DavideIadeluca merged commit 75f95f5 into master Oct 29, 2024
32 checks passed
@DavideIadeluca DavideIadeluca deleted the di/extensibility branch October 29, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imorland imorland imorland approved these changes

Assignees

@DavideIadeluca DavideIadeluca

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DavideIadeluca @imorland