Fix: "Create private discussions with users that block it" permission not working for non-admin users #194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
startPrivateDiscussionWithBlockers
permission keycannotBeDirectMessaged
permission that was not declared anywhere and was alwaysfalse
(but for admin every permission istrue
). Because of this, for example, a moderator who has the permission to create private discussions with users who are blocking them could not create a private discussion with such a user despite having the permission.Reviewers should focus on:
To reproduce:
Create private discussions with users that block it
for non-admin userScreenshots
Confirmed