Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove isRequired propType from I18nRoutingProvider history prop #21

Open
mktoast opened this issue Jan 21, 2019 · 0 comments
Open

Remove isRequired propType from I18nRoutingProvider history prop #21

mktoast opened this issue Jan 21, 2019 · 0 comments

Comments

@mktoast
Copy link
Member

mktoast commented Jan 21, 2019

The history prop is marked as required in the component's PropTypes. We need to remove this propType check to avoid showing the warning if used in server-side.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mktoast