Initial Upgrade to CakePHP 5.x #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please revert the unnecessary changes to |
|
The static analysis error |
ravage84
requested changes
Aug 25, 2023
ADmad
reviewed
Sep 24, 2023
| @@ -21,27 +23,27 @@ class ChecksumTestFixture extends TestFixture | |||
| * | |||
| * @var array<string, string> | |||
| */ | |||
| protected static $_tableHashes = []; | |||
| protected static array $tableHashes = []; | |||
There was a problem hiding this comment.
The removal of underscore from the properties and methods is unnecessary noise.
There was a problem hiding this comment.
@arusinowski the following methods are still changed:
_getTableKey()_tableUnmodified()_hash()
ravage84
requested changes
Sep 25, 2023
| @@ -21,27 +23,27 @@ class ChecksumTestFixture extends TestFixture | |||
| * | |||
| * @var array<string, string> | |||
| */ | |||
| protected static $_tableHashes = []; | |||
| protected static array $tableHashes = []; | |||
There was a problem hiding this comment.
@arusinowski the following methods are still changed:
_getTableKey()_tableUnmodified()_hash()
ravage84
changed the title
ravage84
approved these changes
Sep 25, 2023
ADmad
added a commit
that referenced
this pull request
Oct 13, 2023
Initial Upgrade to CakePHP 5.x (#23)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is fixturize plugin upgraded to CakePHP 5.0, to merge it the
3.nextbranch need to be created. Please review. I will update this branch when the CakePHP5 is released. Thanks