Windows IIS PHP 8.0.12 System error "'""c:\wkhtmltopdf\bin\wkhtmltopdf.exe" is not recognized as an internal or external command

[andraskende]

Hello,

I upgraded PHP from 7.4.16 to 8.0.12 on a windows server..
Fresh install of latest CakePHP 4.3.1 and CakePDF 4.1.1

Configure::write('CakePdf', [
    'engine' => [
        'className' => 'CakePdf.WkHtmlToPdf',
        'binary' => 'c:\wkhtmltopdf\bin\wkhtmltopdf.exe',
    ],
    'pageSize' => 'Letter',
]);

With php 7.4.16 is working fine, with PHP 8.0.12 errors out with:

System error "'""c:\wkhtmltopdf\bin\wkhtmltopdf.exe" --quiet --print-media-type --orientation "portrait" --page-size "Letter" --encoding "UTF-8" - -"' is not recognized as an internal or external command,
operable program or batch file.
" when executing command """c:\wkhtmltopdf\bin\wkhtmltopdf.exe" --quiet --print-media-type --orientation "portrait" --page-size "Letter" --encoding "UTF-8" - -"". Try using the binary/package provided on http://wkhtmltopdf.org/downloads.html
Cake\Core\Exception\CakeException

I figured by adding a condition works fine with php 8.0.12
https://github.com/FriendsOfCake/CakePdf/blob/master/src/Pdf/Engine/WkHtmlToPdfEngine.php#L153-L155

if ($this->_windowsEnvironment && PHP_MAJOR_VERSION < 8) {
    $command = '"' . $command . '"';
}

Could it be related to this change:

https://www.php.net/manual/en/migration80.incompatible.php
On Windows, the program execution functions (proc_open(), exec(), popen() etc.) using the shell, now consistently execute %comspec% /s /c "$commandline", which has the same effect as executing $commandline (without additional quotes).

Thank you!

[ADmad]

Fixed