Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for documentation re: wktohtmlpdf #282

Closed
sdevore opened this issue Apr 25, 2019 · 2 comments
Closed

Suggestion for documentation re: wktohtmlpdf #282

sdevore opened this issue Apr 25, 2019 · 2 comments

Comments

@sdevore
Copy link
Contributor

sdevore commented Apr 25, 2019

So in trying to track down some PDF generation that was very slow > 30 seconds for a 15 page document on a pretty fast server, doing some research ( starting with wkhtmltopdf/wkhtmltopdf#1510 ) and got a fairly significant performance gain just by setting border-radius to 0px or removing altogether. For the same PDF went to < .5 seconds (pdf generation became the fastest part of the generation, the time consuming part shifted to php generating the html to be passed to wktohtmlpdf.

@ADmad
Copy link
Member

ADmad commented Apr 26, 2019

HTML to PDF conversion is tricky business. I am sure each of the engines supported by the plugin have numerous issues/edge cases like this one and at least I don't want to go about documenting them in the plugins' readme. One should just refer to appropriate resources of the provider lib itself.

@sdevore
Copy link
Contributor Author

sdevore commented Apr 27, 2019

Feel free to close, I was just amazed at the improvement.

@sdevore sdevore closed this as completed Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants