Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for V5? #29

Open
ElectricMediaUK opened this issue Jun 4, 2024 · 5 comments
Open

Update for V5? #29

ElectricMediaUK opened this issue Jun 4, 2024 · 5 comments

Comments

@ElectricMediaUK
Copy link

Hello!

Do you have any intention to update the multi-domain plug-in to work with version 5 Mautic?

I hope you do however please can you respond to confirm?

Thanks

@sheddingmyskin
Copy link

Seconding this request.

@miamicityman
Copy link

Bumping request / question.

@clicksmartmedia
Copy link

clicksmartmedia commented Aug 20, 2024

I tried to use this and you just get an error when you install:

[Mon Aug 19 23:58:49.334861 2024] [proxy_fcgi:error] [pid 2958990:tid 2958990] [client 162.157.115.237:57508] AH01071: Got error 'PHP message: PHP Fatal error: Cannot make static method Mautic\\PluginBundle\\Bundle\\PluginBundleBase::onPluginInstall() non static in class MauticPlugin\\MauticMultiDomainBundle\\MauticMultiDomainBundle in /var/www/.ly/docroot/plugins/MauticMultiDomainBundle/MauticMultiDomainBundle.php on line 14; PHP message: PHP Notice: Cannot make static method Mautic\\PluginBundle\\Bundle\\PluginBundleBase::onPluginInstall() non static in class MauticPlugin\\MauticMultiDomainBundle\\MauticMultiDomainBundle - in file /var/www/.ly/..ly/docroot/plugins/MauticMultiDomainBundle/MauticMultiDomainBundle.php - at line 14; PHP message: Symfony\\Component\\ErrorHandler\\Error\\FatalError: Notice: Cannot make static method Mautic\\PluginBundle\\Bundle\\PluginBundleBase::onPluginInstall() non static in class MauticPlugin\\MauticMultiDomainBundle\\MauticMultiDomainBundle - in file /var/www/./..ly/docroot/plugins/MauticMultiDomainBundle/MauticMultiDomainBundle.php - at line 14', referer: https://..//contacts
The "app/bundles/CoreBundle/Resources/views/Offline" directory does not exist ("//app/bundles/CoreBundle/Resources/views/Offline").
Then if you move it out of the directory or delete it works.

Tried to update MauticMultiDomainBundle.php to this...

class MauticMultiDomainBundle extends PluginBundleBase
{
    public static function onPluginInstall(Plugin $plugin, MauticFactory $factory, $metadata = null, $installedSchema = null): void

And it seems to not crash now, but Mautic won't recognize the plugin.

@raramuridesign
Copy link

@jos0405 Is there a chance we can get some feedback if this plugin will be updated for version 5.x.x ?
Thanks
M.

@DT88
Copy link

DT88 commented Nov 6, 2024

Hey team

What is required to get this to v5?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants