Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make seekbar and player controls appear at bottom of video and take full width #6007

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Make seekbar and player controls appear at bottom of video and take full width #6007

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7df41d1
Remove padding and increase width of player controls
ChunkyProgrammer Oct 29, 2024
4c65027
Increase height and set line-height for player buttons
ChunkyProgrammer Nov 24, 2024
f4a7bfe
fix button tooltip position
ChunkyProgrammer Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions src/renderer/components/ft-shaka-video-player/ft-shaka-video-player.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,32 @@
}
}

@media only screen and (width >= 1000px) {
:deep(.shaka-bottom-controls) {
/* remove some bottom padding since the seek bar is above */
padding-bottom: 0;

/* make seekbar take full width on non-mobile devices */
width: 100%;
}

/* increase height of captions area since we remove the padding-bottom below the seekbar */
:deep(.shaka-controls-container[shown='true']~.shaka-text-container) {
bottom: 12.5%;
}

:deep(.shaka-controls-button-panel>button) {
height: 40px;
line-height: 0.5;
}

:deep(.shaka-tooltips-on button:active::after),
:deep(.shaka-tooltips-on button:focus-visible::after),
:deep(.shaka-tooltips-on button:hover::after) {
margin-bottom: 8px;
}
}

@media only screen and (width <=1350px) {
:deep(.theatre-button) {
display: none;
Expand Down
Loading