Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 qualities visually selected when trying to switch video quality - quality does not change #791

Closed
Snake883 opened this issue Nov 15, 2020 · 4 comments
Labels
bug Something isn't working

Comments

@Snake883
Copy link

Snake883 commented Nov 15, 2020

Behavior of the program
When changing the Player quality, the Player's video quality bar does two things:

  1. Multiple quality highlights are displayed.
  2. I'm not sure the quality I selected is actually what FreeTube is playing.
  3. Doesn't seem like I can change/upgrade the quality after selecting a different quality.
  4. Seems like the only quality I can now get is the lowest quality.

Expected behavior
I should get the quality I selected.
I should be able to switch quality while playing video.

To Reproduce
Please add all steps to reproduce the behavior:

  1. Change Player quality while playing video.
  2. Change quality again while playing video.

Screenshots
FT1

Environment Information (please complete the following information):

  • OS: Windows
  • OS Version: 7
  • FreeTube version: 0.9.2
  • Installation Method (If applicable): Portable
  • Primary API Used: Local API
@Snake883 Snake883 added the bug Something isn't working label Nov 15, 2020
@GilgusMaximus
Copy link
Contributor

Hi. So this was mentioned in the Matrix chat as well. It is very likely that VideoJS and the vhs plugin do things under the hood to keep the video running instead of having it buffer.

Reading up on this in the VideoJS doc and looking into possible flags in the VideoJS settings could be worth a shot here. However it will take some time until this can be fixed.

@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Dec 8, 2020

@GilgusMaximus Isnt this a duplicate of #595 like u also mentioned in #734 ?

@GilgusMaximus
Copy link
Contributor

Partially yes. But partially not, because additionally here the UI is mentioned to not work properly. In #595 it is only about not being able to play properly. I might change the title a bit to make it more clear

@GilgusMaximus GilgusMaximus changed the title Switching video playback quality doesn't work. 2 qualities visually selected when trying to switch video quality - quality does not change Dec 9, 2020
@Svallinn
Copy link
Member

This particular bug should be fixed. Let us know otherwise.
NOTE: This bug is considered to be separate from #595

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants