feat: add volume and playback rate change notification feature to vid…

[ikizey]

Pull Request Type

• Feature Implementation

Related issue

closes #4658

Description

it adds small popup in top center of the player, when volume or playback rate is changed using shortcuts (but not ui)

Screenshots

[efb4f5ff-1298-471a-8973-3d47447115dc]

Maybe also use a icon for playbackspeed the same one that is used in the player controls should be fine.

Not sure about the placement would like others to chime in. Does YouTube this with volume and playback speed

firefox_OHfjnbsDIj.mp4

[ikizey]

I wonder about placement too. I'd like to put it in top left corner, but stats are already there.
Not sure about icons. Idea, is '%' in the end indicate volume, and 'x' in the end indicate playback rate.
It's possible to use volumehigh/volumelow icons, but it's confusing, does it mean volume now is high/low, or volume now is higher/lower. So I made a static icon, just to indicate volume is changed.
There is no speed icon in fontawesome, that player uses. So I don't show any.

[kommunarr]

I think the volume low/high icons make sense to indicate down/up. Top middle placement similar to YT here makes sense because the position of these buttons is subject to change, and top middle ensures that it can catch users' attention.

[efb4f5ff-1298-471a-8973-3d47447115dc]

• I think you can put Closes behind the issue in the PR body because this does fully resolve it
• Speed being displayed below actual minimum and above actual maximum

VirtualBoxVM_qdQIXzINZn.mp4

[ikizey]

I placed message in top middle.
Fixed value shown for playback rate.

[ikizey]

Volume icon now shows if volume become higher/lower or muted.

[kommunarr]

This is awesome! Minor notes:

suggestion (blocking): Show mute / current volume popup on mute/unmute with m key.

suggestion (blocking): Show mute icon in popup instead of the volume low icon when using volume down shortcut and hitting 0. Currently, it shows volume low icon when it reaches zero, and you have to press it again to show the mute icon.

nitpick: Don't show trailing zeroes in playback rate popup (e.g., 2.00x). This can be done by calling toString() on it, IIRC.

[ikizey]

suggestion (blocking): Show mute / current volume popup on mute/unmute with m key.

done

suggestion (blocking): Show mute icon in popup instead of the volume low icon when using volume down shortcut and hitting 0. Currently, it shows volume low icon when it reaches zero, and you have to press it again to show the mute icon.

fixed

nitpick: Don't show trailing zeroes in playback rate popup (e.g., 2.00x). This can be
done by calling toString() on it, IIRC.

I did this on purpose. Otherwise if you have step eq. 0.25 and hold o/p values will "jump" inside message.

something like this
| 1.25x |
| 1x |
| 0.75x |
| 0.5x |
now it's like this
| 1.25x |
| 1.00x |
| 0.75x |
| 0.50x |

[efb4f5ff-1298-471a-8973-3d47447115dc]

nitpick: It doesn't fade out elegantly like the player controls. Is it possible to make it do that

VirtualBoxVM_JAWqHudP8y.mp4

[kommunarr]

FWIW, YT also has no transition for it.

[kommunarr]

Would love to have something like this for toasts while in FS / FW 👀

[checktext00]

I also would like to say it would be nice for every single keyboard shortcut affecting the video to have HUD/OSD feedback (like for example pressing left arrow to jump backwards 5 seconds, or when enabling/disabling captions using the "C" key - YouTube has both of these)

• there should also be a play/pause notification when using the space bar and also when using the mouse to click the center of the video (YouTube has this)
• it would be nice if the PIP mode supported these HUD notifications as well