Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build name convention standardization #6423

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

efb4f5ff-1298-471a-8973-3d47447115dc

Build name convention standardization

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

#6415

Description

This PR changes the following:

  • We were using a mix match of hyphens and underscores so this changes all builds to use hyphens instead of underscores. Why hyphens? Most release builds were using hyphens and for nightly builds it was about 50/50 so i opted for hyphens as most normal users (the ones that use release builds) are used to seeing hyphens.
  • Some build names didnt include the .zip extension so i added them
  • if file name contains portable then the following structure is used, platform-architecture-portable. There was a mix of this structure and platform-portable-architecture being used.

Additional context

I will create a PR for our website that will pull the now adjusted release builds. That PR will be drafted as it should be merged right before release.

This is part 2 of making changes in these workflow.
Upcoming parts:

  • Part 3: Group all builds based on platform
  • Part 4: Investigate if all builds have .zip and .7z equivalents

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 20, 2024 17:32
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 20, 2024
@absidue
Copy link
Member

absidue commented Dec 20, 2024

We should probably stick with underscores for the artifacts that electron-builder also uses underscores e.g. the deb files where using underscores to separate the name, version and architecture in the deb file name is a convention .

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants