Fix stats button text color on some themes #6406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
1 task
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Dec 18, 2024
|
This works well! My only thought is if we should apply the active FreeTube theme to the stats menu as well in lieu of this theme-independent dark mode styling.
Edit: The overlay colors probably need to stay the same to ensure a proper color contrast given the lowered transparency, so I think I'm fine with "stats should just be dark mode" as the idea. |
ChunkyProgrammer
approved these changes
Dec 19, 2024
kommunarr
approved these changes
Dec 20, 2024
github-actions
bot
removed
the
PR: waiting for review
|
@kommunarr could you maybe create a feature request for that so it wont get lost |
|
@efb4f5ff-1298-471a-8973-3d47447115dc See my edit to my comment |
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Dec 21, 2024
* development: (57 commits) Translated using Weblate (Ukrainian) Translated using Weblate (Serbian) Translated using Weblate (Hungarian) Translated using Weblate (Icelandic) Translated using Weblate (Estonian) Translated using Weblate (Czech) Translated using Weblate (French) add missing release builds (FreeTubeApp#6415) Translated using Weblate (Serbian) Translated using Weblate (German) Translated using Weblate (Italian) Translated using Weblate (Chinese (Traditional Han script)) apply overflow menu text color change only to overflow menu (not to stats button) (FreeTubeApp#6406) Make a single IPC call for the navigation history (FreeTubeApp#6366) Added buttons to hide hidden channels/text (FreeTubeApp#6156) Translated using Weblate (Serbian) Translated using Weblate (Afrikaans) Translated using Weblate (Afrikaans) Translated using Weblate (Vietnamese) Translated using Weblate (Afrikaans) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix stats button text color on some themes
Pull Request Type
Related issue
bug introduced in #6213
Description
The text color change introduced in #6213 inadvertently also applies to the text in the Stats button, which can render it nearly invisible depending on your theme (Gruvbox Light, for instance). This PR makes it so that the text color change applies only to the intended texts in the overflow menu.
Screenshots
Before:
After:
Desktop